Skip to content

fix/accessibility-issues - #2498

Open
rizviammar579 wants to merge 3 commits into
beautifier:mainfrom
rizviammar579:fix/accessibility-issues
Open

fix/accessibility-issues#2498
rizviammar579 wants to merge 3 commits into
beautifier:mainfrom
rizviammar579:fix/accessibility-issues

Conversation

@rizviammar579

Copy link
Copy Markdown

Related Issue

#2496

Previous Behaviour

  • Theme toggle was not accessible via keyboard (Tab/Space did not work).
  • NVDA screen reader only announced “checkbox checked / not checked” without context.
  • Visually impaired users had no indication that the checkbox represented Dark Mode.

New Behaviour

  • Theme toggle is now fully accessible through keyboard navigation (Tab + Space).
  • NVDA screen reader correctly announces:
    “Dark Mode checkbox checked / not checked”
    providing clear and contextual feedback for visually impaired users.

What Changed

  • Removed display: none style from the checkbox input tag, which was blocking keyboard accessibility.
  • Moved theme text into the <label> to resolve the accessible name bug.
  • Adjusted CSS to preserve the original UI look after moving text into the label.
  • Ensured that the visual design remains consistent with the previous implementation while fixing accessibility.

Relation to Previous Issue

#2483

  • This PR also include fixes from my previously raised issue since the problems were interrelated.
  • Bundling them together ensures a cleaner merge process .

@rizviammar579

Copy link
Copy Markdown
Author

Hi @bitwiseman , thanks for the review! Just checking in as the required workflows are still awaiting approval. Please let me know if anything is needed from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants