fix: prevent handlebars helpers from triggering HTML optional end tag… - #2436
Closed
SarthakDudhe wants to merge 3 commits into
Closed
fix: prevent handlebars helpers from triggering HTML optional end tag…#2436SarthakDudhe wants to merge 3 commits into
SarthakDudhe wants to merge 3 commits into
Conversation
Member
Add an automated test. |
bitwiseman
requested changes
Jun 21, 2026
bitwiseman
left a comment
bitwiseman
left a comment
Member
There was a problem hiding this comment.
Waiting for automated test.
Member
|
@SarthakDudhe I'm mass-closing your PRs for clarity. Feel free to reopen individual PRs when you've updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #2045. Prevents Handlebars helpers (like {{#tr}}) from being incorrectly treated as HTML tags.
Changes: Updated _do_optional_end_element in beautifier.js to ensure HTML-specific tag omission rules only trigger for tags starting with <. This prevents templating helpers from accidentally "popping" the tag stack and breaking indentation.
Testing: Verified that {{#tr}} now maintains correct indentation inside . All 11,904 existing HTML tests passed.