-
Notifications
You must be signed in to change notification settings - Fork 276
WS-2562 - Update WS Languages page navigation #14074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
5f9d112
update divider colour
louisearchibald 285f365
add bbc blocks to languages page
louisearchibald 1640d22
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald 4904057
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald a4cfcee
pass isLanguagesPage prop to legacy brand container
louisearchibald 26dd65a
update red banner height to 44px for languages page
louisearchibald e1ad83e
update brandsvg
louisearchibald 94234f6
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald 412e4a7
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald 82acdba
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald b40bbb6
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald 1de887c
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald e64ed25
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald 493e57d
update viewbox values
louisearchibald 7ac57be
undo previously added media queries
louisearchibald 3bcd782
Revert "undo previously added media queries"
louisearchibald 4ddf0d0
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald 40b7eb0
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald 63bb589
set brand header to 44px on languages page by passing isLanguagesPage…
louisearchibald e744334
small refactor to ensure languages page picks up correct padding
louisearchibald 0ad3aa6
fix svg sizing at group 3 breakpoint
louisearchibald c044916
bbc blocks on languages homepage link to bbc.com
louisearchibald 818ee72
ensure footer styles are not being affected
louisearchibald c502364
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald 6ecffc1
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald 575f26a
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald dfd700c
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald d33ab10
Revert "bbc blocks on languages homepage link to bbc.com"
louisearchibald 9352e3e
Merge branch 'latest' into WS-2562-update-ws-languages-page-navigation
louisearchibald 894b1cc
Merge branch 'WS-2562-update-ws-languages-page-navigation' of ssh://g…
louisearchibald b356389
further prevent footer logo from inheriting languages page styles
louisearchibald d1fb202
smol change
louisearchibald 6e11182
export existing path helpers
louisearchibald c4854f2
scope styling changes to ws/languages only
louisearchibald 27b5545
scope nav changes to ws/languages only
louisearchibald fb438cb
add storybook example to show correct nav changes for ws/languages
louisearchibald 446163c
add unit tests checking for logo banner on languages page
louisearchibald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.