Skip to content

WS-2003: Portrait Carousel on Live Pages - #14005

Merged
HarveyPeachey merged 17 commits into
latestfrom
WS-2003-live-pv-carousel
May 13, 2026
Merged

WS-2003: Portrait Carousel on Live Pages#14005
HarveyPeachey merged 17 commits into
latestfrom
WS-2003-live-pv-carousel

Conversation

@HarveyPeachey

@HarveyPeachey HarveyPeachey commented May 11, 2026

Copy link
Copy Markdown
Contributor

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2003

Summary

Adds PV carousel onto live pages when found in page data
image

Code changes

  • Adds PV carousel to second section before stream
  • Makes PV carousel title optional
  • Adds logic to only render title when prop exists
  • Removes flex styling from second section (Don't think it's needed?)
  • Fixes a small naming bug with overflowWrap, (whilst I was here)

Testing

  1. List the steps required to test this PR.

Useful Links

Comment thread ws-nextjs-app/pages/[service]/live/[id]/styles.ts
Co-authored-by: Copilot <copilot@github.com>
@HarveyPeachey HarveyPeachey changed the title Ws 2003 live pv carousel WS-2003: Portrait Carousel on Live Pages May 12, 2026
@HarveyPeachey HarveyPeachey self-assigned this May 12, 2026
@HarveyPeachey
HarveyPeachey marked this pull request as ready for review May 12, 2026 07:50
@HarveyPeachey
HarveyPeachey requested review from Copilot May 12, 2026 07:50

@HarveyPeachey HarveyPeachey left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will get UX to take a look to see if the number of promos is suitable for the container size

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for rendering the Portrait Video (PV) carousel on Next.js live pages when portrait video items are present in the live page payload, and updates the shared PortraitVideoCarousel component to allow omission of a visible title.

Changes:

  • Render PortraitVideoCarousel on live pages (in the second section, before the stream) when portraitVideoItems exist.
  • Make the carousel title optional and only render the heading when a title is provided.
  • Update live page styling and tests; fix overflowWrap naming in live label header styles.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ws-nextjs-app/pages/[service]/live/[id]/styles.ts Removes flex centering from the live page second section to accommodate the new carousel + stream layout.
ws-nextjs-app/pages/[service]/live/[id]/LivePageLayout.tsx Adds conditional live-page rendering of PortraitVideoCarousel using portraitVideoItems.
ws-nextjs-app/pages/[service]/live/[id]/live.test.tsx Mocks and asserts carousel rendering when portraitVideoItems are provided.
ws-nextjs-app/pages/[service]/live/[id]/Header/LiveLabelHeader/index.styles.ts Fixes overflowWrap style key naming.
src/app/components/PortraitVideoCarousel/index.tsx Makes title optional; conditionally renders heading; introduces aria-label fallback.
src/app/components/PortraitVideoCarousel/index.test.tsx Adds a test for rendering the carousel without a title.

Comment thread src/app/components/PortraitVideoCarousel/index.tsx
Comment thread src/app/components/PortraitVideoCarousel/index.test.tsx
Comment thread ws-nextjs-app/pages/[service]/live/[id]/LivePageLayout.tsx Outdated
Comment thread ws-nextjs-app/pages/[service]/live/[id]/LivePageLayout.tsx
@HarveyPeachey
HarveyPeachey merged commit e9bfd5c into latest May 13, 2026
12 checks passed
@HarveyPeachey
HarveyPeachey deleted the WS-2003-live-pv-carousel branch May 13, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants