-
Notifications
You must be signed in to change notification settings - Fork 7
Epic A: Workflow & CI Governance (Sprint 1) #9708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: leader
Are you sure you want to change the base?
Changes from 1 commit
8036e0a
5ac2062
a3494b2
cd1de24
31929f7
23aa757
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| ### Summary | ||
|
|
||
| ### Risk & Scope | ||
| - [ ] Low risk | ||
| - [ ] Medium risk | ||
| - [ ] High risk (requires ai:required or risk:high label) | ||
|
|
||
| ### Architecture Compliance | ||
| - [ ] No transport logic added in React components | ||
| - [ ] No server-only modules imported into client code | ||
| - [ ] Service/store boundaries preserved (service -> store -> hooks -> components) | ||
|
|
||
| ### Service/Store Impact | ||
| - [ ] Touches service layer (list files): | ||
| - [ ] Touches state store/reducer (list files): | ||
| - [ ] Migration/backward compatibility considered | ||
|
|
||
| ### Auth/Security | ||
| - [ ] Affects auth/session/token flow | ||
| - [ ] WebSocket upgrade/auth assumptions reviewed | ||
| - [ ] No secrets introduced in code/config/logs | ||
|
|
||
| ### Testing | ||
| - [ ] Lint/type/knip pass locally | ||
| - [ ] Unit tests updated | ||
| - [ ] Integration tests updated | ||
| - [ ] VRT/E2E impact assessed | ||
|
|
||
| ### Accessibility | ||
| - [ ] Realtime announcements use correct aria-live strategy | ||
| - [ ] No high-frequency screen-reader spam introduced | ||
| - [ ] Contrast/accessibility checks considered |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Auto-merge Dependencies | ||
|
|
||
| on: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Auto Rebase | ||
|
|
||
| on: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Bot Command Orchestrator | ||
|
|
||
| on: | ||
|
|
@@ -145,9 +148,9 @@ jobs: | |
| # Find the branch name of the PR | ||
| BRANCH=$(gh pr view "$PR_NUMBER" --json headRefName -q .headRefName) | ||
|
|
||
| # Find the most recent successful run of 'Gemini Orchestrator' (pr-orchestrator.yml) for this branch. | ||
| # Find the most recent successful run of 'PR Quality' (pr-quality.yml) for this branch. | ||
| # This workflow produces the 'review-result' artifact. | ||
| RUN_ID=$(gh run list --workflow pr-orchestrator.yml --branch "$BRANCH" --status success --limit 1 --json databaseId -q '.[0].databaseId') | ||
| RUN_ID=$(gh run list --workflow pr-quality.yml --branch "$BRANCH" --status success --limit 1 --json databaseId -q '.[0].databaseId') | ||
|
Comment on lines
+156
to
+158
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Manual Useful? React with 👍 / 👎. |
||
|
|
||
| # Fallback: check 'Bot Command Orchestrator' if manual review was triggered | ||
| if [ -z "$RUN_ID" ]; then | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Lint Commit Messages | ||
| on: [pull_request] | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Deploy Production | ||
|
|
||
| on: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: 'E2E CI Tests' | ||
|
|
||
| on: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # owner: @team-devex | ||
| # purpose: Standard automation workflow | ||
|
|
||
| name: Manual Release (Local Deployment) | ||
|
|
||
| on: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direct mode safety checks currently fail open:
--deterministic-passeddefaults to"true", and risk-path blocking only runs when--changed-filesis explicitly provided. In the new@jules-new --directpath, callers can omit both inputs, so direct mode is allowed even when deterministic checks failed or high-risk files changed, which bypasses the guardrails this change is meant to enforce.Useful? React with 👍 / 👎.