fix: revert #25294 #28276
Draft
santi1s wants to merge 3 commits into
Draft
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportBundle size has no change ✅ |
This reverts commit 5444415. Signed-off-by: Sergio Santiago <sergio.santiago@doctolib.com>
ba93ad9 to
0fc0cc5
Compare
Signed-off-by: Sergio Santiago <sergio.santiago@doctolib.com>
Move the getOpenAPISchema call inside the RespectIgnoreDifferences=true block so it is only invoked when the feature is actually used. This avoids requiring all existing tests to stub GetOpenAPISchema on their ClusterCache mocks. Signed-off-by: Sergio Santiago <sergio.santiago@doctolib.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28276 +/- ##
=========================================
Coverage ? 64.84%
=========================================
Files ? 425
Lines ? 59118
Branches ? 0
=========================================
Hits ? 38333
Misses ? 17222
Partials ? 3563 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25294, restoring the fix originally introduced in #24197.
#25294reverted#24197(CRD array elementignoreDifferencessupport) due to a nil pointer dereference (#25199). That underlying issue has since been resolved upstream per thediscussion in #17694.
Closes #23283
Checklist: