feat(health): support various policies _.microgateway.airlock.com#28268
feat(health): support various policies _.microgateway.airlock.com#28268root30 wants to merge 3 commits into
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportBundle size has no change ✅ |
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
016b61e to
90bd417
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28268 +/- ##
==========================================
+ Coverage 65.08% 65.09% +0.01%
==========================================
Files 425 425
Lines 59293 59293
==========================================
+ Hits 38590 38596 +6
+ Misses 17131 17127 -4
+ Partials 3572 3570 -2 ☔ View full report in Codecov by Harness. |
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
2 times, most recently
from
c8d02c1 to
eddfbc9
Compare
| hs.status = "Healthy" | ||
| hs.message = (obj.kind or "Policy") .. " is healthy" |
There was a problem hiding this comment.
My reading of this is that if any ancestor is healthy, we'll basically ignore any ancestors that are still progressing but that do not yet have the Accepted condition yet... Maybe the "Healthy" path should be a final loop that confirms that all ancestors are healthy?
There was a problem hiding this comment.
You are right! I added a test case for that behavior and changed the logic accordingly.
Signed-off-by: Roman Willi <roman.willi@ergon.ch>
… microgateway.airlock.com API group Signed-off-by: Roman Willi <roman.willi@ergon.ch>
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
5edfddf to
270f391
Compare
…check Signed-off-by: Roman Willi <roman.willi@ergon.ch>
root30
force-pushed
the
resource-customizations-microgateway-policies
branch
from
270f391 to
546d52c
Compare
| group: gateway.networking.k8s.io | ||
| kind: Gateway | ||
| name: example-gateway | ||
| conditions: [] |
There was a problem hiding this comment.
An empty conditions struct is not valid (according to policy_types.go), however conditions would be required within the ancestors struct as well... in that case it does not matter though
2 participants
This PR adds the custom health check for various policy Types of Airlock Microgateway.
Checklist: