Skip to content

feat(health): support various policies _.microgateway.airlock.com - #28268

Merged
crenshaw-dev merged 4 commits into
argoproj:masterfrom
root30:resource-customizations-microgateway-policies
Jun 21, 2026
Merged

feat(health): support various policies _.microgateway.airlock.com#28268
crenshaw-dev merged 4 commits into
argoproj:masterfrom
root30:resource-customizations-microgateway-policies

Conversation

@root30

@root30 root30 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This PR adds the custom health check for various policy Types of Airlock Microgateway.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell

bunnyshell Bot commented Jun 12, 2026

Copy link
Copy Markdown

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@root30
root30 force-pushed the resource-customizations-microgateway-policies branch from 016b61e to 90bd417 Compare June 12, 2026 12:45
@root30
root30 marked this pull request as ready for review June 12, 2026 12:45
@root30
root30 requested a review from a team as a code owner June 12, 2026 12:45
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.05%. Comparing base (a4ec66e) to head (c88968c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28268      +/-   ##
==========================================
- Coverage   65.05%   65.05%   -0.01%     
==========================================
  Files         425      425              
  Lines       59415    59422       +7     
==========================================
+ Hits        38654    38658       +4     
+ Misses      17186    17183       -3     
- Partials     3575     3581       +6     
Flag Coverage Δ
e2e 26.62% <ø> (+<0.01%) ⬆️
unit-tests 60.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Comment thread resource_customizations/microgateway.airlock.com/_/health.lua
@root30
root30 force-pushed the resource-customizations-microgateway-policies branch 2 times, most recently from c8d02c1 to eddfbc9 Compare June 15, 2026 07:39
@root30
root30 requested a review from crenshaw-dev June 15, 2026 14:02
Comment thread resource_customizations/microgateway.airlock.com/_/health.lua
@root30
root30 force-pushed the resource-customizations-microgateway-policies branch 2 times, most recently from 270f391 to 546d52c Compare June 16, 2026 13:11
group: gateway.networking.k8s.io
kind: Gateway
name: example-gateway
conditions: []

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty conditions struct is not valid (according to policy_types.go), however conditions would be required within the ancestors struct as well... in that case it does not matter though

@root30
root30 force-pushed the resource-customizations-microgateway-policies branch from 546d52c to 1365207 Compare June 17, 2026 06:25
root30 added 3 commits June 18, 2026 14:47
Signed-off-by: Roman Willi <roman.willi@ergon.ch>
… microgateway.airlock.com API group

Signed-off-by: Roman Willi <roman.willi@ergon.ch>
…check

Signed-off-by: Roman Willi <roman.willi@ergon.ch>
@root30
root30 force-pushed the resource-customizations-microgateway-policies branch from 1365207 to 8c28c08 Compare June 18, 2026 12:47
@root30
root30 requested a review from crenshaw-dev June 18, 2026 12:47
@crenshaw-dev
crenshaw-dev enabled auto-merge (squash) June 21, 2026 18:14
@crenshaw-dev
crenshaw-dev merged commit 5e8ed63 into argoproj:master Jun 21, 2026
28 checks passed
om7057 pushed a commit to om7057/argo-cd that referenced this pull request Jun 24, 2026
amarkdotdev added a commit to amarkdotdev/argo-cd that referenced this pull request Jul 21, 2026
…goproj#28268)

Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
@root30
root30 deleted the resource-customizations-microgateway-policies branch July 27, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants