Skip to content

fix(ssa): do not run auth reconcile with SSA (cherry pick of #28027 and #27601 to 3.4)#28265

Open
Mangaal wants to merge 2 commits into
argoproj:release-3.4from
Mangaal:cherry-pick-27601-27624-release-3.4-test-4
Open

fix(ssa): do not run auth reconcile with SSA (cherry pick of #28027 and #27601 to 3.4)#28265
Mangaal wants to merge 2 commits into
argoproj:release-3.4from
Mangaal:cherry-pick-27601-27624-release-3.4-test-4

Conversation

@Mangaal

@Mangaal Mangaal commented Jun 12, 2026

Copy link
Copy Markdown
Member

I am manually creating this PR to cherry pick because auto cherry pick has conflicts

Original PRs #28027 and #27601

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…oj#27601)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
(cherry picked from commit 8feb146)
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
(cherry picked from commit 0acae9a)
@Mangaal Mangaal requested a review from a team as a code owner June 12, 2026 09:48
@akhilnittala

Copy link
Copy Markdown

Tested scenario mentioned for #26175, working fine as expected.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.63934% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.80%. Comparing base (7f2fe95) to head (0fff269).

Files with missing lines Patch % Lines
gitops-engine/pkg/utils/kube/resource_ops.go 61.38% 33 Missing and 6 partials ⚠️
gitops-engine/pkg/utils/kube/ctl.go 0.00% 11 Missing ⚠️
gitops-engine/pkg/utils/kube/kubetest/mock.go 0.00% 4 Missing ⚠️
util/kube/kubectl.go 0.00% 2 Missing ⚠️
controller/sync.go 0.00% 1 Missing ⚠️
gitops-engine/pkg/sync/sync_context.go 0.00% 1 Missing ⚠️
server/application/application.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.4   #28265      +/-   ##
===============================================
+ Coverage        63.48%   63.80%   +0.31%     
===============================================
  Files              414      414              
  Lines            56610    56551      -59     
===============================================
+ Hits             35941    36080     +139     
+ Misses           17289    17079     -210     
- Partials          3380     3392      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants