fix(ui): replace pod CLI download link with GitHub releases link (#27805)#28264
Open
KKamJi98 wants to merge 1 commit into
Open
fix(ui): replace pod CLI download link with GitHub releases link (#27805)#28264KKamJi98 wants to merge 1 commit into
KKamJi98 wants to merge 1 commit into
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportChanges will increase total bundle size by 153 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: argo-cd-ui-array-pushAssets Changed:
|
2ef700e to
2a506ac
Compare
…oproj#27805) The help page offered a single Linux binary served from the pod, which is the wrong binary for macOS/Windows/arm users and a surprisingly large download. Link to the GitHub releases page for the running version instead. Admins can still expose direct download buttons (internal mirrors, air-gapped) via the existing help.download.<os>-<arch> keys, which can also point at the binary the server serves at download/argocd-linux-<arch>. Signed-off-by: KKamJi <xowl5460@naver.com>
2a506ac to
c11bef9
Compare
kunalworldwide
left a comment
There was a problem hiding this comment.
Clean PR. A few things I checked:
- Version regex
^v\d+\.\d+\.\d+(-[0-9A-Za-z.]+)?$correctly matches release tags (v3.4.1) and pre-release (v3.4.0-rc1), while sending build metadata versions (+) to the generic releases list. Makes sense since+builds don't have GitHub release tags. - External link correctly uses
target='_blank' rel='noopener noreferrer'. - Backward compat for air-gapped setups preserved —
help.download.<os>-<arch>ConfigMap keys still work, and the server still serves its embedded binary atdownload/argocd-linux-<arch>. - Test coverage is good — covers released versions, RC, dev builds, empty string, and undefined.
- Docs update removes the stale note about duplicate Linux buttons.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help page offered a single Linux binary served from the pod, which is the wrong binary for macOS, Windows and arm users and a surprise ~200MB download from the cluster.
Per the discussion in the issue, the button now links to the GitHub releases page for the running version instead: straight to the release tag when the server reports one (
v3.4.1,v3.4.0-rc1), or the releases list for dev builds (v3.5.0+0dc5b3f).Admins who want direct download buttons (internal mirrors, air-gapped clusters) can still configure them with the existing
help.download.<os>-<arch>keys, and those can point at the binary the server keeps serving atdownload/argocd-linux-<arch>. Updated the operator docs to match.Closes #27805
Checklist: