chore: remove obsolete buster-backports apt source from builder stages#28250
Open
crenshaw-dev wants to merge 1 commit into
Open
chore: remove obsolete buster-backports apt source from builder stages#28250crenshaw-dev wants to merge 1 commit into
crenshaw-dev wants to merge 1 commit into
Conversation
The backports repo was originally added to install git-lfs from apt on Debian-based golang builder images. It is no longer needed now that git-lfs is installed via install.sh and golang:1.26.4 is based on Debian Trixie where all remaining builder packages are in main repos. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28250 +/- ##
=========================================
Coverage ? 64.75%
=========================================
Files ? 424
Lines ? 58714
Branches ? 0
=========================================
Hits ? 38021
Misses ? 17161
Partials ? 3532 ☔ View full report in Codecov by Harness. |
blakepettersson
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the stale
buster-backportsapt source from the golang builder stages inDockerfileandDockerfile.tilt.This repo line was originally added in #1941 (July 2019) to install
git-lfsfrom Debian backports on the golang/Debian-based builder image. At the time,git-lfswas not available in Debian Stretch/Buster main repos.Since then:
argocd-baseswitched to Ubuntu and dropped the backports line (Ubuntu hadgit-lfsin its own repos), but it was left on the builder stage because that stage still uses the golang/Debian image.deb.debian.orgtoarchive.debian.orgafter active Debian mirrors dropped buster-backports.git-lfswas removed fromapt installand is now installed viainstall.sh, but the backports line was not cleaned up.The golang image is now Debian Trixie (13), and all remaining builder packages (
nginx,fcgiwrap,openssh-server, etc.) are available in main repos without backports. The Ubuntu base image stages are unaffected — they use the built-inresolutesources fromubuntu:26.04.There is no indication
git-lfswill move back to apt: #26465 moved it toinstall.shbecause upstream stopped publishing Debian packages as of 3.7.0, and the project now pins the version inhack/tool-versions.shlike helm and kustomize.Test plan
docker build --target buildersucceeds without the backports lineChecklist:
Made with Cursor