Skip to content

chore: remove obsolete buster-backports apt source from builder stages#28250

Open
crenshaw-dev wants to merge 1 commit into
masterfrom
remove-unnecessary-source
Open

chore: remove obsolete buster-backports apt source from builder stages#28250
crenshaw-dev wants to merge 1 commit into
masterfrom
remove-unnecessary-source

Conversation

@crenshaw-dev

Copy link
Copy Markdown
Member

Summary

Remove the stale buster-backports apt source from the golang builder stages in Dockerfile and Dockerfile.tilt.

This repo line was originally added in #1941 (July 2019) to install git-lfs from Debian backports on the golang/Debian-based builder image. At the time, git-lfs was not available in Debian Stretch/Buster main repos.

Since then:

The golang image is now Debian Trixie (13), and all remaining builder packages (nginx, fcgiwrap, openssh-server, etc.) are available in main repos without backports. The Ubuntu base image stages are unaffected — they use the built-in resolute sources from ubuntu:26.04.

There is no indication git-lfs will move back to apt: #26465 moved it to install.sh because upstream stopped publishing Debian packages as of 3.7.0, and the project now pins the version in hack/tool-versions.sh like helm and kustomize.

Test plan

  • Verified docker build --target builder succeeds without the backports line

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Made with Cursor

The backports repo was originally added to install git-lfs from apt on
Debian-based golang builder images. It is no longer needed now that
git-lfs is installed via install.sh and golang:1.26.4 is based on
Debian Trixie where all remaining builder packages are in main repos.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner June 11, 2026 18:24
@bunnyshell

bunnyshell Bot commented Jun 11, 2026

Copy link
Copy Markdown

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@08e959d). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #28250   +/-   ##
=========================================
  Coverage          ?   64.75%           
=========================================
  Files             ?      424           
  Lines             ?    58714           
  Branches          ?        0           
=========================================
  Hits              ?    38021           
  Misses            ?    17161           
  Partials          ?     3532           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants