feat: add selector-based ignoreResourceUpdates config for orphaned resources#28223
Open
maheshz09 wants to merge 2 commits into
Open
feat: add selector-based ignoreResourceUpdates config for orphaned resources#28223maheshz09 wants to merge 2 commits into
maheshz09 wants to merge 2 commits into
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
maheshz09
force-pushed
the
feat/ignore-orphaned-resource-updates
branch
from
405fafb to
ac63c1f
Compare
Bundle ReportBundle size has no change ✅ |
Adds support for configuring ignoreResourceUpdates behavior for
orphaned resources via name patterns in argocd-cm, removing the
need for external tools like Kyverno to inject annotations.
Operators can now configure in argocd-cm:
resource.orphaned.ignore.namePatterns: |
namePatterns:
- "*-cluster-config-map"
- "*-config-map"
Fixes argoproj#28099
Signed-off-by: Mahesh Pansare <maheshpansare099+github@gmail.com>
maheshz09
force-pushed
the
feat/ignore-orphaned-resource-updates
branch
from
ac63c1f to
d3dfa64
Compare
Signed-off-by: Mahesh Pansare <138249606+maheshz09@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28099
Currently the only way to apply
ignoreResourceUpdatesbehavior toorphaned resources (managed by operators) is by setting the annotation
argocd.argoproj.io/ignore-resource-updates: "true"via Kyvernomutating policies. This adds a native config option in argocd-cm.
Changes
resource.orphaned.ignore.namePatternsconfig key in argocd-cmOrphanedResourceIgnoreConfigstruct andGetOrphanedResourceIgnoreConfig()inutil/settingsisOrphanedResourceIgnored()helper in appcontrollerUsage
Add to argocd-cm: