add tiptap's subscript and superscript extansion to tiptap wysiwyg#2732
add tiptap's subscript and superscript extansion to tiptap wysiwyg#2732tommycornilleau wants to merge 3 commits into
Conversation
|
|
| subscript: true, | ||
| superscript: true, |
There was a problem hiding this comment.
This will enable them by default on all Tiptap fields where the developer passes an empty array of options, which I don't think should be the case in a minor release.
There was a problem hiding this comment.
Indeed, this was probably too much
| 'subscript', | ||
| 'superscript', |
There was a problem hiding this comment.
Same here, if the developer does not specify their options in a field, they will end up with new buttons after updating Twill, which I consider as a "breaking" change. We should remove it from this default configuration for now. We might decide to add them back for the next major release.
| "@tiptap/extension-subscript": "^2.11.5", | ||
| "@tiptap/extension-superscript": "^2.11.5", |
There was a problem hiding this comment.
When new npm dependencies are added, the package.lock file needs to be pushed to the repository.
… and add package-lonk
# Conflicts: # package-lock.json
|
Changes request has been addressed. |
3 participants
Add subscript or superscript content in TipTap wysiwyg
Subscript uses @tiptap/extension-subscript and wrap wysiwyg text within a
<sub />tag.Superscript uses @tiptap/extension-superscript and wrap wysiwyg text within a
<sup />tag.