Migrate runtime-spark-tests to server runner#4900
Open
snazy wants to merge 1 commit into
Open
Conversation
dimas-b
reviewed
Jun 27, 2026
|
|
||
| static PropertiesRustfsAccess from(Path path) { | ||
| Properties properties = new Properties(); | ||
| try (InputStream input = java.nio.file.Files.newInputStream(path)) { |
| hiveRustfs = | ||
| new RustfsContainer(null, RUSTFS_ACCESS_KEY, RUSTFS_SECRET_KEY, null, "us-west-2") | ||
| .withStartupAttempts(5); | ||
| hiveRustfs.start(); |
Contributor
There was a problem hiding this comment.
From my POV it would be preferable to extent the server runner framework to allow tests to control the starting of the Polaris server too, before we convert more modules to the new runner.
Cf. #4856 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.