Fix GCS downscoped credential prefix boundary for locations without trailing slash#4884
Merged
dimas-b merged 1 commit intoJun 26, 2026
Conversation
dimas-b
reviewed
Jun 24, 2026
5cf552b to
72522a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the CEL expressions used for GCS credential downscoping in
GcpCredentialsStorageIntegration.When a table or namespace location does not end with
/(e.g.gs://bucket/db/table), the previousstartsWithrules could match sibling prefixes such asdb/table2ordb/table-secret/....The fix updates both the resource name condition and the list prefix condition:
/or are empty keep the existingstartsWithbehaviour.startsWith('<path>/') || resource.name == '<path>'(and the symmetric form for theobjectListPrefixattribute).Changes
resourceNameStartsWithExpression(...)andobjectListPrefixStartsWithExpression(...)testGenerateAccessBoundaryPreventsSiblingPrefixBypassCHANGELOG.mdThis is a security hardening change for subscoped storage credentials.
Checklist
CHANGELOG.mdsite/content/in-dev/unreleased(not needed for this internal fix)