fix(admin) - centralize drop-failure error mapping and fix misleading messages#4793
Open
vigneshio wants to merge 1 commit into
Open
fix(admin) - centralize drop-failure error mapping and fix misleading messages#4793vigneshio wants to merge 1 commit into
vigneshio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change improves error messages when deleting catalogs, principals, and roles.
Previously, all delete failures were reported using messages meant for protected roles or admin roles, even when the real problem was something else. For example, if a normal principal like
alicewas deleted while being updated concurrently, the API could return:That message incorrectly identifies
aliceas the root principal.Now, each delete failure type returns a more accurate error:
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)