feat: write snapshot v3 row lineage fields at top level#791
Merged
Conversation
blackmwk
approved these changes
Jun 29, 2026
zhjwpku
approved these changes
Jun 29, 2026
manuzhang
reviewed
Jun 29, 2026
manuzhang
reviewed
Jun 29, 2026
Member
Author
|
Thanks @manuzhang for the comment. Good catch! |
manuzhang
reviewed
Jun 30, 2026
| parent_snapshot_id == other.parent_snapshot_id && | ||
| sequence_number == other.sequence_number && timestamp_ms == other.timestamp_ms && | ||
| schema_id == other.schema_id; | ||
| schema_id == other.schema_id && first_row_id == other.first_row_id && |
Member
There was a problem hiding this comment.
Not sure these fields are required in equals. Java implementation doesn't have them.
Member
Author
There was a problem hiding this comment.
It looks odd if two snapshots with different row lineage attributes are deemed identical. I would rather think this is an oversight from apache/iceberg#11948. Both iceberg-rust and iceberg-python enforce all fields to be equal so I think it is fine to include them here.
Member
There was a problem hiding this comment.
Agreed. Opened apache/iceberg#17015 to fix at Java side.
manuzhang
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.