Skip to content

Potential fix for environment variable built from user-controlled sources #38942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
derrickaw wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −2
Draft

Potential fix for environment variable built from user-controlled sources #38942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/beam_Publish_Beam_SDK_Snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,21 @@ jobs:
# This is needed to run pipelines that use the default environment at HEAD, for example, when a
# pipeline uses an expansion service built from HEAD.
run: |
BEAM_VERSION_LINE=$(cat gradle.properties | grep "sdk_version")
echo "BEAM_VERSION=${BEAM_VERSION_LINE#*sdk_version=}" >> $GITHUB_ENV
BEAM_VERSION_LINE=$(grep -m1 '^sdk_version=' gradle.properties || true)
if [ -z "$BEAM_VERSION_LINE" ]; then
echo "Could not find sdk_version in gradle.properties"
exit 1
fi

BEAM_VERSION="${BEAM_VERSION_LINE#sdk_version=}"

# Prevent environment file injection via CR/LF.
if printf '%s' "$BEAM_VERSION" | grep -q $'[\r\n]'; then
echo "Invalid sdk_version: contains newline characters"
exit 1
fi

printf 'BEAM_VERSION=%s\n' "$BEAM_VERSION" >> "$GITHUB_ENV"
- name: Set latest tag only on master branch
if: github.ref == 'refs/heads/master'
run: echo "LATEST_TAG=,latest" >> $GITHUB_ENV
Expand Down
Loading