fix uv cache lock contention in parallel installGcpTest#38918
fix uv cache lock contention in parallel installGcpTest#38918aIbrahiim wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a concurrency issue where multiple parallel test executions were competing for the same UV cache lock. By isolating the cache directory on a per-project basis, the build process is now more robust against contention during dependency installation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures a per-project UV_CACHE_DIR environment variable in the Gradle build script to prevent sdist lock contention during parallel installations, alongside triggering post-commit tests. The reviewer suggests converting the relative path of UV_CACHE_DIR to an absolute path using project.file(...).absolutePath to ensure robustness against working directory changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
| project.exec { | ||
| // Per-project uv cache avoids sdist lock contention in parallel installGcpTest. | ||
| environment 'UV_CACHE_DIR', "${project.ext.envdir}/.uv-cache" |
There was a problem hiding this comment.
Using a relative path for UV_CACHE_DIR can be problematic if the execution's working directory changes or if uv resolves relative paths unexpectedly. Converting it to an absolute path using project.file(...).absolutePath is more robust and ensures a standard String is passed to the environment.
environment 'UV_CACHE_DIR', project.file("${project.ext.envdir}/.uv-cache").absolutePath
1 participant
Fixes: #38813
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.