GH-50236: Remove obsolete OpenSUSE 15.5 workarounds#50258
Open
Shally-Katariya wants to merge 1 commit into
Open
GH-50236: Remove obsolete OpenSUSE 15.5 workarounds#50258Shally-Katariya wants to merge 1 commit into
Shally-Katariya wants to merge 1 commit into
Conversation
Member
|
@Shally-Katariya Can you fix the C++ formatting? You should be able to do it using |
5494d3e to
571fe82
Compare
pitrou
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Apache Arrow no longer supports the OpenSUSE 15.5 build configuration that required explicit
shared_ptrandunique_ptrconstructions.This PR removes obsolete OpenSUSE 15.5-specific workarounds and simplifies the affected return statements by relying on standard implicit conversions.
What changes are included in this PR?
std::shared_ptr<T>(std::move(...))constructions with direct returns.std::unique_ptr<T>(std::move(...))constructions with direct returns.Are these changes tested?
Yes.
The changes were verified by building the affected components and running the relevant compute test suite:
ninja arrow-compute-tests ctest -R "arrow-compute" --output-on-failureAll tests passed successfully.
Are there any user-facing changes?
No. This change is an internal code cleanup and does not affect public APIs, behavior, or user-facing functionality.