Support ID3/RIFF INFO/ReplayGain metadata in WAV extractor#3265
Open
nift4 wants to merge 1 commit into
Open
Conversation
nift4
force-pushed
the
wavmetadata
branch
3 times, most recently
from
dfdacb3 to
06c2466
Compare
Including flag for returning prior behavior if seeking to end of file to find metadata chunks there (as old WAV readers do not support chunks between format and data, metadata is often put after data) is undesirable. Currently sample_rf64 test fails due to seeking more than max int value, and I will need some guidance on how exactly you can seek after the data segment if it's more than integer max value, as I can neither skipFully() nor seek numbers that high. The RIFF INFO tag names have been pieced together from "Multimedia Programming Interface and Data Specifications 1.0" (1991), exiftool, Hydrogen Audio, FFmpeg and wavemetatools. Samples created from other samples are also included, these were made with Kid3 and Awave Audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including flag for returning prior behavior if seeking to end of file to find metadata chunks there (as old WAV readers do not support chunks between format and data, metadata is often put after data) is undesirable.
Currently sample_rf64 test fails due to seeking more than max int value, and I will need some guidance on how exactly you can seek after the data segment if it's more than integer max value, as I can neither skipFully() nor seek numbers that high.
The RIFF INFO tag names have been pieced together from "Multimedia Programming Interface and Data Specifications 1.0" (1991), exiftool, Hydrogen Audio, FFmpeg and wavemetatools.
Samples created from other samples are also included, these were made with Kid3 and Awave Audio.