Skip to content

Detect FLAC bit depth in mka container#3261

Open
nift4 wants to merge 2 commits into
androidx:mainfrom
nift4:flacinmka
Open

Detect FLAC bit depth in mka container#3261
nift4 wants to merge 2 commits into
androidx:mainfrom
nift4:flacinmka

Conversation

@nift4
Copy link
Copy Markdown
Contributor

@nift4 nift4 commented Jun 4, 2026

No description provided.

@icbaker icbaker self-assigned this Jun 4, 2026
copybara-service Bot pushed a commit that referenced this pull request Jun 4, 2026
This is a precursor to merging Issue: #3261

PiperOrigin-RevId: 926623920
@icbaker
Copy link
Copy Markdown
Collaborator

icbaker commented Jun 5, 2026

Thanks for this, it prompted me to do a couple of test-related changes first:

  1. Run the existing FLAC-in-MKA assets through MatroskaExtractorTest (so we can see the impact of this change in the dumps): c92d88e
  2. Re-write the pcmEncoding test dump value to be human-readable: 1effe5b

I'll rebase this on top of those, update the test dumps, and send it for internal review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants