Skip to content

test(webui): deflake SettingsPage dynamic-tools toggle tests #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itomek wants to merge 2 commits into from
Closed

test(webui): deflake SettingsPage dynamic-tools toggle tests #1938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b080830
test(webui): fix SettingsPage toggle flake — wait for loaded state
Jul 6, 2026
cf78e8b
Merge branch 'main' into fix-settings-toggle-flake
itomek Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/gaia/apps/webui/src/components/__tests__/SettingsPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ function getDynamicToolsToggle(): HTMLInputElement {
describe('SettingsPage — Dynamic Tools toggle (#1798)', () => {
it('renders the loaded value (off by default)', async () => {
render(<SettingsPage />);
const toggle = await waitFor(getDynamicToolsToggle);
expect(toggle).not.toBeChecked();
expect(toggle).not.toBeDisabled();
// Disabled-while-loading: wait for the enabled (loaded) state, not
// just the element, or slow runners race the settings fetch.
await waitFor(() => expect(getDynamicToolsToggle()).not.toBeDisabled());
expect(getDynamicToolsToggle()).not.toBeChecked();
});

it('reflects a persisted-on value from the server', async () => {
Expand Down Expand Up @@ -94,10 +95,11 @@ describe('SettingsPage — Dynamic Tools toggle (#1798)', () => {
makeSettings({ dynamic_tools: true, dynamic_tools_locked: true }),
);
render(<SettingsPage />);
const toggle = await waitFor(getDynamicToolsToggle);
// The toggle exists (disabled, unchecked) while settings load — wait
// for the loaded state, not just the element, or slow runners race.
await waitFor(() => expect(getDynamicToolsToggle()).toBeChecked());

expect(toggle).toBeChecked();
expect(toggle).toBeDisabled();
expect(getDynamicToolsToggle()).toBeDisabled();
expect(screen.getByText(/GAIA_DYNAMIC_TOOLS/)).toBeInTheDocument();
});

Expand Down
Loading