Fix DOM text reinterpreted as HTML in enhanced-textbox#5953
Open
kr8n3r wants to merge 1 commit into
Open
Conversation
This is to avoid any potential XSS vectors of attack. `contentReplaced` method was updated to now create a `DocumentFragment` look through string of characters in the textarea and wrap any placeholders in `span` depending on their type (regular vs optional). It then returns original text (without placeholders) and placeholder values. `contentEscaped` method can be removed as we now apply text that doesn't contain any placeholders directly in the `update` method. `update` method was update to use `.textContent` to apply raw text as the browser substitues < and > characters to harmless < and > For text with placeholders we use `.append` which works in teh same way as `.textContent`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid any potential XSS vectors of attack.
Resolves
https://github.com/alphagov/notifications-admin/security/code-scanning/3
https://github.com/alphagov/notifications-admin/security/code-scanning/4
contentReplacedmethod was updated to now create aDocumentFragmentlook through string of characters in the textarea and wrap any placeholders inspandepending on their type (regular vs optional). It then returns original text (without placeholders) and placeholder values.contentEscapedmethod can be removed as we now apply text that doesn't contain any placeholders directly in theupdatemethod.updatemethod was updated to use.textContentto apply raw text as the browser substitues < and > characters to harmless < and >For text with placeholders we use
.appendwhich works in the same way as.textContent.