Skip to content

notify api clients: use a common thread-local requests.Session #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
risicle wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

notify api clients: use a common thread-local requests.Session #5394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71fae3
TMP bump notifications-python-client
risicle Mar 2, 2025
4f87d76
notify api clients: use a common thread-local requests.Session
risicle Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pyexcel-io==0.6.6
pyexcel-xls==0.7.0
pyexcel-xlsx==0.6.0
pyexcel-ods3==0.6.1
notifications-python-client==10.0.0
notifications-python-client @ git+https://github.com/alphagov/notifications-python-client.git@5eafd129144f5006e2d7bf501a9c38450979d4b6

@CrystalPea CrystalPea Mar 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I can see this is a TEMP bump - what plan do we have to ensure this temp doesn't become a semi-permanent thing that will throw someone later?

Also is there a PR for these python client changes that needs reviewing?

@risicle risicle Mar 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ linked in the PR description

fido2==1.1.3

# Run `make bump-utils` to update to the latest version
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ markupsafe==2.1.1
# wtforms
mistune==0.8.4
# via notifications-utils
notifications-python-client==10.0.0
notifications-python-client @ git+https://github.com/alphagov/notifications-python-client.git@5eafd129144f5006e2d7bf501a9c38450979d4b6
# via -r requirements.in
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@d6311c3ab83b8225265277f781157c48f9318ae9
# via -r requirements.in
Expand Down
2 changes: 1 addition & 1 deletion requirements_for_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ mistune==0.8.4
# notifications-utils
moto==4.0.9
# via -r requirements_for_test.in
notifications-python-client==10.0.0
notifications-python-client @ git+https://github.com/alphagov/notifications-python-client.git@5eafd129144f5006e2d7bf501a9c38450979d4b6
# via -r requirements.txt
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@d6311c3ab83b8225265277f781157c48f9318ae9
# via -r requirements.txt
Expand Down