Add more accurate BadRequest handling - #5786
Open
KludgeKML wants to merge 1 commit into
Open
Conversation
- Currently bad requests are getting intercepted by some default method that translates them into 503s. Add explict capture.
KludgeKML
force-pushed
the
strict-content-store
branch
from
September 10, 2026 13:36
da936e0 to
7b3a1cc
Compare
KludgeKML
marked this pull request as ready for review
September 10, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit capture/report of BadRequests from GdsApi::HTTPBadRequest
Why
Currently bad requests are getting turned into 503s, which means they turn up in Sentry. We should ideally not be alerting on these, so return a correct 400 (this will be important when we include gds-api-adapters 103.5.0, which returns BadRequest immediately when we ask content store for a path that doesn't conform to RFC-192