[DO NOT MERGE] Impact header different image size - #5735
Draft
andysellick wants to merge 1 commit into
Draft
Conversation
andysellick
force-pushed
the
impact-header-prototype
branch
from
September 7, 2026 15:21
2e0901c to
b123e4e
Compare
- modify the impact header on desktop to remove the specific sizing of the image to be square - the best way to do this without breaking any existing images seems to be to remove the height specifications and rely on the image dimensions - to allow for this we remove the vertical centering of the text on the left, and apply top padding instead - this allows us to refactor the caption markup so it sits beneath the image (previously this had to be separate because the expanded details element would cause the text on the left to move with the changing height of the overall component)
andysellick
force-pushed
the
impact-header-prototype
branch
from
September 7, 2026 15:24
b123e4e to
05b3245
Compare
andysellick
changed the title
AshGDS
reviewed
Sep 8, 2026
| } | ||
| } | ||
|
|
||
| .app-c-impact-header__image-thing { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Exploring design options so we can have landscape aspect ratio images in the impact header instead of squares.
Need to be aware of existing use like https://www.gov.uk/government/topical-events/youth-matters-national-youth-strategy
Visual changes
Image now sets the height of the component, as shown with this new example.
The text changes position slightly as it is no longer vertically aligned to centre, but the nature of this change means it won't impact (no pun intended) existing instances of the component, like on https://www.gov.uk/government/topical-events/youth-matters-national-youth-strategy