Add map download file size to travel advice download link [WHIT-2598] - #5109
Merged
Conversation
GDSNewt
changed the title
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 3, 2025 10:58
2b8eb45 to
ada2dec
Compare
ChrisBAshton
approved these changes
Nov 4, 2025
ChrisBAshton
left a comment
ChrisBAshton
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but we should hold off on merging until the corresponding bit in TAP is implemented. (Also needs a review from the team that owns Frontend)
GDSNewt
changed the title
jon-kirwan
reviewed
Nov 5, 2025
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 11, 2025 16:28
ada2dec to
101b8ab
Compare
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 11, 2025 16:53
101b8ab to
51babe4
Compare
ChrisBAshton
approved these changes
Nov 11, 2025
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 12, 2025 15:53
51babe4 to
24414b8
Compare
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 12, 2025 15:58
24414b8 to
a7819b1
Compare
GDSNewt
force-pushed
the
add-file-size-to-download-link
branch
from
November 12, 2025 16:03
a7819b1 to
1f6acf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Makes download size visible to users so they can decide whether to download mobile-data-heavy files. This was identified as an issue in a DAC review.
Corresponding backend PR: alphagov/travel-advice-publisher#2394
Jira card