Fix vscript variant EHANDLE conversions#390
Merged
Merged
Conversation
Kenzzer
approved these changes
Jun 4, 2026
Kenzzer
left a comment
Kenzzer
left a comment
Member
There was a problem hiding this comment.
Well that explains the fix I had to perform alliedmodders/sourcemod@047dd0d
I could not understand where that came from. Just like you suggested, I'm against restoring the sourcemod hack. Better to follow what is official. Real funny however that official valve code is broken and our sourcemod hack muted this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a0d9a0f synced the hl2sdk with the Source SDK 2013. Unfortunately, this reverted a SourceMod-specific hack that was introduced in another sync commit:
hl2sdk/public/basehandle.h
Lines 36 to 37 in ebd971b
This being reverted now causes compilation errors for any extension relying on it. One case I ran into is the vscript CVariantBase. However, instead of restoring the hack, I'd rather just fix the SDK bug.
I have submitted the same fix to the Source SDK 2013 repo: ValveSoftware/source-sdk-2013#1948