Add 'sort' filter to specify results order - #57
Open
JackSwingle01 wants to merge 2 commits into
Open
Conversation
Owner
|
Hey @JackSwingle01 thanks for the PR and sorry it's taken me a while to get to it. I'm trying to slowly move any validation logic out of the I'm happy to pick up those changes too if you want to give me write permission to your branch. |
Added sort filter based on https://blog.gdeltproject.org/gdelt-doc-2-0-api-debuts/
Moves the sort type check out of the Filters class and into a standalone validate_sort function alongside validate_tone, as requested in review. VALID_SORT_TYPES moves with it. Adds unit tests for validate_sort and for the sort filter's effect on the generated query string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Author
|
Hey @alex9smith sorry about taking so long to get to this, let me know if what I added in the last commit is what you're looking for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sort filter based on https://blog.gdeltproject.org/gdelt-doc-2-0-api-debuts/