chore(wallet): remove cosmos-kit integration and deps from deploy-web#3313
Open
baktun14 wants to merge 3 commits into
Open
chore(wallet): remove cosmos-kit integration and deps from deploy-web#3313baktun14 wants to merge 3 commits into
baktun14 wants to merge 3 commits into
Conversation
Delete the dead cosmos-kit wallet-connection stack (cosmos-kit-jotai abstraction, chain-registry configs, and the no-op CustomChainProvider bootstrap wrapper) now that deploy-web is managed-wallet only, and uninstall the cosmos-kit / chain-registry / interchain-ui packages. @cosmjs/* is intentionally retained: it is still required for tx-message building in customRegistry/TxHttpService. Removing it depends on moving transaction construction and signing into the API (tracked separately). Ref CON-259
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves the cosmos-kit-jotai wallet infrastructure from Changescosmos-kit-jotai wallet stack removal and styling update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -543,18 +543,12 @@ | |||
| "@cosmjs/math": "~0.38.0", | |||
Contributor
There was a problem hiding this comment.
🔄 Carefully review the package-lock.json diff
Resolve the comment if everything is ok
- apps/deploy-web/node_modules/@cosmjs/amino 0.38.1
- apps/deploy-web/node_modules/@cosmjs/crypto 0.38.1
- apps/deploy-web/node_modules/@cosmjs/utils 0.38.1
- apps/deploy-web/node_modules/@cosmos-kit/react 2.24.1
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@chain-registry/types 0.46.15
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/amino 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/crypto 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/encoding 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/math 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/proto-signing 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmjs/utils 0.32.4
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@cosmos-kit/react-lite 2.18.1
- apps/deploy-web/node_modules/@cosmos-kit/react/node_modules/@dao-dao/cosmiframe 1.0.0
- apps/deploy-web/node_modules/@interchain-ui/react 1.26.3
- apps/deploy-web/node_modules/@noble/ciphers 1.3.0
- apps/deploy-web/node_modules/@noble/curves 1.9.7
- node_modules/appwrite 14.0.1
- node_modules/appwrite/node_modules/cross-fetch 3.1.5
- node_modules/appwrite/node_modules/node-fetch 2.6.7
- node_modules/@cosmos-kit/cosmos-extension-metamask 0.15.1
- node_modules/@cosmos-kit/cosmostation-extension 2.18.1
- node_modules/@cosmos-kit/keplr 2.17.1
- node_modules/@cosmsnap/snapper 0.2.7
- node_modules/@cosmsnap/snapper/node_modules/@cosmjs/amino 0.31.3
- node_modules/@cosmsnap/snapper/node_modules/@cosmjs/crypto 0.31.3
- node_modules/@cosmsnap/snapper/node_modules/@cosmjs/encoding 0.31.3
- node_modules/@cosmsnap/snapper/node_modules/@cosmjs/math 0.31.3
- node_modules/@cosmsnap/snapper/node_modules/@cosmjs/utils 0.31.3
- node_modules/@cosmsnap/snapper/node_modules/@keplr-wallet/proto-types 0.12.12
- node_modules/isomorphic-form-data 2.0.0
- node_modules/isomorphic-form-data/node_modules/form-data 2.5.1
- node_modules/@keplr-wallet/types 0.12.12
- node_modules/@keplr-wallet/types/node_modules/long 4.0.0
- node_modules/node-appwrite 14.1.0
- node_modules/node-fetch-native-with-agent 1.7.2
- node_modules/ses 0.18.4
- node_modules/@vanilla-extract/css-utils 0.1.6 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
+ Coverage 68.81% 68.85% +0.03%
==========================================
Files 1096 1080 -16
Lines 26837 26482 -355
Branches 6435 6366 -69
==========================================
- Hits 18468 18233 -235
+ Misses 7326 7223 -103
+ Partials 1043 1026 -17
🚀 New features to boost your workflow:
|
Modals/popups render in a portal at document.body, outside the app's <main> that carries GeistSans.variable, so --font-geist-sans was undefined there and they fell back to the browser serif default. This was previously masked by a global font injected by @interchain-ui, which was removed alongside cosmos-kit. Define the font variable on <Html> and set an explicit body font-family so portaled content inherits Geist.
@cosmjs/amino was only pulled in by the removed cosmos-kit signing code; knip flags it as an unused devDependency. Remove it to keep the dependency set clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes CON-259
deploy-webis now managed-wallet only (self-custody lives in the separate Console Air app per AEP-84). The entire cosmos-kit wallet-connection stack was dead code: nothing outside it importeduseChain/useManager/the wallet modal/the chain configs, and all signing already goes server-side viaTxHttpService. Keeping these packages installed only bloated the bundle.What
Removed the dead cosmos-kit stack and its dependencies from
deploy-web:cosmos-kit-jotaiabstraction layer, thesrc/chains/*chain-registry configs, and the no-opCustomChainProviderbootstrap wrapper (unwrapped from_app.tsx).@cosmos-kit/core,@cosmos-kit/react,@cosmos-kit/keplr,@cosmos-kit/cosmostation-extension,@cosmos-kit/cosmos-extension-metamask,chain-registry,@chain-registry/types, and@interchain-ui/react(33 packages removed from the lockfile).NEXT_PUBLIC_WALLET_CONNECT_PROJECT_IDenv var.Scope note on
@cosmjs/*(descoped AC)The AC item "searching for
@cosmjsreturns zero matches" is not addressed here and is intentionally deferred.@cosmjs/*is still required by the managed flow —customRegistry.ts(consumed byTxHttpService) builds the txRegistryfrom@cosmjs/proto-signing+@cosmjs/stargate, plusEncodeObject/Decimal/base64 usage. The issue author already flagged this with "verify;TransactionMessageDatamay still needEncodeObject". Removing@cosmjsrequires the API to own transaction building+signing first, now tracked as follow-ups:@cosmjscriterion)Verification
grep @cosmos-kit / chain-registry / @interchain-ui / cosmos-kit-jotaiinapps/deploy-web/src→ 0 matchestsc,lint --quiet, unit tests,next buildall pass (the only pre-existing tsc/test failures onmainare unrelated and unchanged by this PR)Bundle size (before → after
next build)pages/_appchunk (raw)pages/_appsource mapSummary by CodeRabbit
Release Notes