fix(provider): resolve bids from sibling wallets sharing a hostUri#25
Open
baktun14 wants to merge 1 commit into
Open
fix(provider): resolve bids from sibling wallets sharing a hostUri#25baktun14 wants to merge 1 commit into
baktun14 wants to merge 1 commit into
Conversation
When multiple Provider wallets share the same hostUri, the deduped provider list returned by the API only includes one canonical wallet. Bids on the chain can be submitted by any of the sibling wallets, so the prior `providers.find(p => p.owner === bid.provider)` lookup returned undefined for non-canonical wallets, leaving empty rows in the bid list and breaking manifest send. Resolve bids via owner OR the new `aliasOwners` field on the canonical row, and filter the bid list to providers that are online and on a valid version so users no longer see unselectable empty rows.
Draft
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When multiple Provider wallets share the same hostUri on-chain, the API's deduped provider list (
/v1/providers) only includes one canonical wallet per hostUri. Bids on the chain can be submitted by any of the sibling wallets, but the priorproviders.find(p => p.owner === bid.provider)lookup returned undefined for non-canonical wallets — leaving empty rows in the bid list, breaking the audited/search filters, and throwing "Cannot find bid provider" on manifest send.This is the console-air mirror of the fix landing in
akash-network/console(which adds the API-sidealiasOwnersfield). Once the API change is deployed, console-air consumes the new field via the existing/v1/providerscall — no client API change is needed here, only the UI resolution + filter.Fixes CON-375
What
aliasOwners: string[]toApiProviderList(matches the API contract change in the main console repo).findProviderForBidProvider(providers, bidProvider)toproviderUtils.ts— resolves a bid's provider byownerOR byaliasOwners.BidGroup.tsx(display) andCreateLease.tsx(manifest send + search filter + audited filter).buildProvidertest seeder + add focused unit tests for the helper.