Fix coverage for test_benchmarks.py#251
Open
Vizonex wants to merge 23 commits into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into coverage-change
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (97.87%) is below the target coverage (98.20%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
===========================================
+ Coverage 99.54% 100.00% +0.45%
===========================================
Files 10 10
Lines 439 437 -2
Branches 17 17
===========================================
Hits 437 437
+ Misses 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Vizonex
changed the title
test_benchmarks.pytest_benchmarks.py
for more information, see https://pre-commit.ci
…into coverage-change
webknjaz
reviewed
May 23, 2026
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
Besides the suggestions below, plz look into the possibility to integrate covdefaults into the project in a follow-up PR.
| bools | ||
| changelog | ||
| changelogs | ||
| codspeed |
Member
There was a problem hiding this comment.
These are libraries, I think it's better to just surround the words with backticks like code, rather than filling the spelling list with all of them.
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,16 +1,20 @@ | |||
| """codspeed benchmarks for propcache.""" | |||
|
|
|||
| import typing as _t | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change omits a common problem with coverage that is causing a lot of workflows in this repo to fail which is in
tests/test_benchmarks.pyThis was a recommendation by the new ai agent.Are there changes in behavior for the user?
Nope. The only thing this affects is contributors and maintainers.
Related issue number
#245 (This is to help it pass)
#245 (comment)
Checklist