perf(datapath): remove unused fields from sub/unsub messages mirrored…#1584
Open
markpmarton wants to merge 11 commits into
Open
perf(datapath): remove unused fields from sub/unsub messages mirrored…#1584markpmarton wants to merge 11 commits into
markpmarton wants to merge 11 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
… to control-plane Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
34dbd87 to
b8fa79f
Compare
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Mark Marton <30534230+markpmarton@users.noreply.github.com>
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1387
Description
Remote Subscribe and Unsubscribe messages are sent by the receiver Data-Plane to the Control-Plane. As the Control-Plane processes only the destination name and the subscription_id, it is unnecessary to mirror the complete message to CP.
Actions
Results
In my environment (Macbook M4 Pro) I experienced a minor improvement in the latency of the process_stream function (with mocked CP connection) in the cost of slightly higher heap allocation.
In conclusion: no significant improvement achieved (0.5-2%), because only sub/unsub messages were affected which don't contain a lot of data in the first place.
Although the change doesn't provide significant improvement, due to the added bench tests, this PR might still be worth merging.
Type of Change
Checklist