feat(Lungo-UI): Centralized error handling - #712
Merged
Conversation
delthazor
reviewed
Jul 22, 2026
delthazor
left a comment
Contributor
There was a problem hiding this comment.
The solution is comprehensive, and very solid. I think it is good overall, I just had small nitpicks.
pregnor
previously approved these changes
Jul 22, 2026
pregnor
left a comment
Contributor
There was a problem hiding this comment.
LGTM at a glance, looked good on the live show
Contributor
Author
pregnor
previously approved these changes
Jul 23, 2026
pregnor
left a comment
Contributor
There was a problem hiding this comment.
LGTM still, just fix the CI issues
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
pregnor
previously approved these changes
Jul 24, 2026
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
…Error Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
…tores Signed-off-by: misi-bp <mkaloczy@cisco.com>
…ll HTTP calls use the fetch-based client. Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
…nt types Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
…after the axios-fetchJson refactor Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
…ormatting Signed-off-by: misi-bp <mkaloczy@cisco.com>
…d pattern chat Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Signed-off-by: misi-bp <mkaloczy@cisco.com>
… slug throw in modal catch Signed-off-by: misi-bp <mkaloczy@cisco.com>
…al body2 style Signed-off-by: misi-bp <mkaloczy@cisco.com>
misi-bp
force-pushed
the
648/error-handling
branch
from
July 24, 2026 14:10
7a460aa to
84957ee
Compare
13 tasks
pregnor
approved these changes
Jul 27, 2026
delthazor
approved these changes
Jul 27, 2026
delthazor
left a comment
Contributor
There was a problem hiding this comment.
Pretty robust, let's see it in action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Overhaul Lungo frontend networking and failure handling: replace axios with a shared fetch stack, centralize URLs and request targets, report API errors consistently, and surface actionable messages across chat, streaming, agentic graph, and modals. Follow-up commits on this branch align
reportRequestErrorlabels with fetch targets, fix graph OASF/identity edge cases, and document the pipeline for maintainers.Description
HTTP client and URL layer
httpFetchand helpers:fetchJson,fetchNdjsonStream,fetchSse(shared SSE frame parsing).HttpError,parseHttpError, andendpointLabelon errors for logging and UI metadata.urls.ts(apiPaths, env-backed bases) andhttpRequestTargets.ts/HttpRequestTargetbuilders; migrateagenticWorkflowsClientand catalog consumers to fetch.workflowChatRoutingresolves prompt/stream/suggested-prompt URLs fromWorkflowSummary.chat_api_targetand streaming flags.Error reporting and global UI
reportRequestError: structured dev/prod logging; optionaluserMessage→ global notification banner viaerrorNotificationStore.reportUiError,ErrorBoundarywith recoverable fallback, and error notification banner onRootPage.sourcepreferHttpError.endpointLabelwhen the transport layer set it.Chat and streaming
fetchNdjsonStream+reportRequestError; sharedndjsonStreamingStatus/ stream teardown hardening.useAppsplit into focused hooks (useAppPromptHandlers, streaming effects, workflow catalog, pattern reference, etc.).Graph, modals, and identity
LoadingErrorState, compact negative empty states) for badge, policy, OASF, and about flows.reportRequestErrorin graph modals uses the sameendpointLabelas the fetch (badgeDetailsRequest,oasfRecordRequest, pattern chat/documentation builders).useNodeTransportInterfaces: pass workflowchat_api_targetintofetchOasfRecord(fixes logistics OASF 404s to exchange port); cache empty transport results to avoid refetch loops.catchwhen slug resolution fails.body2label/value rows).UI polish and dependencies
CustomNodeonly; dark-mode resting rail label contrast; compact-group layout padding split.Content-Type: application/jsonon JSON POST bodies (fixes 422 on/agent/promptafter axios removal).@open-ui-kit/coreto 2.2.3; prefer OUK imports over direct MUI where touched; security-related dependency updates and tsconfig adjustments.Documentation
reportRequestErrorcontract, and per-feature error presentation map.Tests
parseHttpError,reportRequestError,ErrorBoundary, workflow chat routing, agentic workflows API parsing, topology/identity UI map, and related regressions.Issue link
Fixes #648
Type of change
Checklist