Skip to content

Remix dropdown: add styles even if running inside a remix preview #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 2 commits into from
Jun 29, 2026
+13 −9
Merged

Remix dropdown: add styles even if running inside a remix preview #5843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f498c43
Add styles even if running inside a remix preview, so the Open Sandbo…
vincentfretin Jun 29, 2026
3fd0321
Use preview param for Krabbel to specify which file to open in editor…
vincentfretin Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions examples/js/remix-dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,26 @@
}

function init () {
addStyles();

// Don't show the button when the example is already running inside a remix
// service preview (CodeSandbox *.csb.app, Krabbel *.krabbel.fun).
if (/\.(csb\.app|krabbel\.fun)$/.test(window.location.hostname)) { return; }

var loc = getExampleLocation();
if (!loc) { return; }

// Point at the directory, adding a file parameter for non-index.html pages
// so the specific example file is opened. The leading slash is URL-encoded
// (CodeSandbox expects %2F).
var fileParam = (loc.file && loc.file !== 'index.html') ? '?file=' + encodeURIComponent('/' + loc.file) : '';
var treePath = 'tree/gh-pages/examples/' + loc.dir + fileParam;
var codesandboxUrl = 'https://codesandbox.io/p/sandbox/github/aframevr/aframe/' + treePath;
var krabbelUrl = 'https://krabbel.dev/github/aframevr/aframe/' + treePath;

addStyles();
// Point at the directory, adding a parameter for non-index.html pages so the
// specific example file is opened. CodeSandbox uses a file parameter (with a
// leading slash, URL-encoded as %2F); Krabbel supports file and preview parameters
// (leading slash optional, if preview parameter specified and file parameter not
// specified, it will open the same file in both editor and preview).
var treePath = 'tree/gh-pages/examples/' + loc.dir;
var isFile = loc.file && loc.file !== 'index.html';
var fileParam = isFile ? '?file=' + encodeURIComponent('/' + loc.file) : '';
var previewParam = isFile ? '?preview=' + encodeURIComponent(loc.file) : '';
var codesandboxUrl = 'https://codesandbox.io/p/sandbox/github/aframevr/aframe/' + treePath + fileParam;
var krabbelUrl = 'https://krabbel.dev/github/aframevr/aframe/' + treePath + previewParam;

var menu = document.createElement('div');
menu.classList.add('a-remix-menu');
Expand Down
Loading