Reposition CodeSandbox button in gh-pages examples#5839
Closed
vincentfretin wants to merge 2 commits into
Closed
Conversation
Move the CodeSandbox "Open Sandbox" button to the top so it does not overlap the VR/AR enter buttons, only in the example pages where a CDN link was actually replaced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…p right on some examples
Contributor
Author
|
Alternative is to include the css rule directly in aframe.css #5841 but it will be working only in the next aframe release. |
Member
|
injecting perhaps si a bit too magical. we can add it to aframe styles. I can redeploy the examples |
Contributor
Author
|
We actually need a new aframe build so a new official release 1.8.1 to make the aframe styles effective. Closing this one since #5841 is merged. I will create another PR with my proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When generating the gh-pages examples, inject a small
<style>block that moves the CodeSandbox "Open Sandbox" button to the top of the page so it no longer overlaps the VR/AR enter buttons.The style is only injected into the example HTML pages where a CDN link was actually replaced (tracked via the
hasChangedresult fromreplace-in-file), so untouched pages are left alone.🤖 Generated with Claude Code