Point gh-pages examples at the released A-Frame CDN build#5838
Merged
Conversation
Rewrite the example aframe-master.js and aframe-master.module.min.js references to https://aframe.io/releases/<version>/aframe(.module).min.js, taking the version from package.json. Read the super-three version from the released tag's package.json instead of master so the examples reference the three version that shipped with this release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 24, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the example aframe-master.js and aframe-master.module.min.js references to
https://aframe.io/releases/<version>/aframe(.module).min.js, taking the version from package.json. Read the super-three version from the released tag's package.json instead of master so the examples reference the three version that shipped with this release.