fix(rsvp): restore optionOrders support dropped by c811f37 - #210
Open
qiyundai wants to merge 1 commit into
Open
Conversation
c811f37 dropped rsvpFormFields.optionOrders entirely, with a comment claiming ESP's RSVPFormFields schema only supports { required, visible }. That's stale: ESP added optionOrders (openapi.json, ScopeConfigRsvpField) in events-service-platform PR #1002, well before c811f37 landed. Restore building/reading optionOrders so per-field option overrides round-trip instead of being silently dropped, and fix EventApiResponse.rsvpFormFields to match the flat ESP shape (it still had the unused old { fields } shape).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c811f37droppedrsvpFormFields.optionOrdersentirely, with a comment claiming ESP'sRSVPFormFieldsschema only supports{ required, visible }. That's stale — ESP addedoptionOrdersinevents-service-platformPR #1002, beforec811f37landed (confirmed against latestdevelop,openapi.jsonScopeConfigRsvpField).optionOrderson save (useEventFormSave.ts) and reading it back on load (eventFormMappers.ts) so per-field option overrides round-trip instead of being silently dropped.EventApiResponse.rsvpFormFields(types/domain.ts) to match ESP's actual flat shape — it still had an unused{ fields: [...] }shape left over from an earlier migration plan that never shipped.Test plan
npm run check(lint + type-check) passesselect/checkboxfield that has a per-field option override; save, reload, and confirm the option order/whitelist round-tripsconsole.warnabout dropped options appears anymore