Skip to content

chore: update eslint plugin react hooks#10174

Draft
snowystinger wants to merge 1 commit into
mainfrom
update-eslint-plugin-react-hooks
Draft

chore: update eslint plugin react hooks#10174
snowystinger wants to merge 1 commit into
mainfrom
update-eslint-plugin-react-hooks

Conversation

@snowystinger

Copy link
Copy Markdown
Member

Pointed out here #10150 (comment)

Which does fail in https://playground.react.dev/#N4Igzg9grgTgxgUxALhAgHgBwjALgAgBMEAzAQygBsCSoA7OXASwjvwFkBPAQU0wAoAlPmAAdNvkoICAW04AlUvgC8+KGASKS-OlUqCA3OPyTp+AG5lKUBCrUb2CGRH5CVAPhH5jJ-DGmwbHJaAHRwsP50uEYSAL4ANPgA2gC6hj5SBJHEMAAqTDK2qsGkYREIUTEm-riB+AA8hEzm7gASCJSUEPgA6jiUhCKW1gixItkIeQWj9QD0TS0xseIg8SBwrCRMAOYoIGISs7MbMphMlGTMrOwQxMjeIFaUoiDisavgABYQAO4AklFJnQrGAUORKBpYkA

However, it's not currently failing in this PR... so I'm not sure if something else is causing it to bail or we need to update something else. But if we try to use the compiler, it'll error on that line.

I haven't started fixing any of the errors yet.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant