fix: prevent DropZone focus on hidden file input click#10173
Open
pradeep-ramola wants to merge 1 commit into
Open
fix: prevent DropZone focus on hidden file input click#10173pradeep-ramola wants to merge 1 commit into
pradeep-ramola wants to merge 1 commit into
Conversation
pradeep-ramola
force-pushed
the
pradeep-ramola/dropzone-filetrigger-focus-scroll
branch
from
b7c329e to
c37dbff
Compare
snowystinger
previously requested changes
Jun 9, 2026
snowystinger
left a comment
snowystinger
left a comment
Member
There was a problem hiding this comment.
Thanks for the interest, but this is not the right fix. Please see #10092 (comment)
pradeep-ramola
force-pushed
the
pradeep-ramola/dropzone-filetrigger-focus-scroll
branch
from
c37dbff to
c14eee0
Compare
Author
|
Thanks for the pointer. I removed the FileTrigger/input-click guard and revised this to preserve the existing focus fallback. The PR now proposes an opt-in Happy to adjust the API shape or naming if you’d prefer a different direction. |
snowystinger
dismissed
their stale review
PR updated, will re-review later. Removing my block though.
snowystinger
approved these changes
Jun 11, 2026
snowystinger
left a comment
snowystinger
left a comment
Member
There was a problem hiding this comment.
Verified that it works by editing the node_modules in the example repo to have the same code change.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10092
When a
FileTriggeris used inside aDropZone, its hidden file input can dispatch a programmatic click that bubbles to the DropZone. Since the hidden input is not focusable, DropZone treats the event like a click on non-focusable dropzone content and focuses its visually hidden drop button, which can scroll positioned overflow ancestors.This ignores hidden file input clicks in DropZone's fallback focus handling and adds a regression test that verifies the visible FileTrigger button keeps focus.