Skip to content

wip: enable keyboard scrolling in S2 Popover when content overflows #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yihuiliao wants to merge 7 commits into
base: main
Choose a base branch
from
+27 −4
Draft

wip: enable keyboard scrolling in S2 Popover when content overflows #10091

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec0f952
fix: enable keyboard scrolling in S2 Popover when content overflows
yihuiliao May 20, 2026
7657f46
fix formatting
yihuiliao May 20, 2026
58b074e
cleanup
yihuiliao May 20, 2026
30b298c
Merge branch 'main' into scroll-popover
yihuiliao May 28, 2026
6844600
Merge branch 'main' into scroll-popover
yihuiliao Jun 3, 2026
a0b1ede
move back to outline to prevent layout shift
yihuiliao Jun 3, 2026
9d3725b
a slightly different solution
yihuiliao Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/@react-spectrum/s2/src/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,13 @@ let popover = style(
default: 'elevated',
isArrowShown: 'none'
},
outlineStyle: 'solid',

@yihuiliao yihuiliao May 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I'm not sure if there was reason we were using outline over borders. However, since overflow: auto was moved to the popover and not inner div, the outline was appearing on top of the scrollbar. Using border ensures that it appears underneath.

*ignore the squished image, i didn't want it take up too much space but you can see where the outline is

@yihuiliao yihuiliao Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for context, i previously changed the popover to use border instead of outline bc the outline was now rendering on top of the scrollbar since i move overflow: auto to the outer div. but this caused the popover to shift bc borders participate in the box models whereas outline doesn't. we could move to box shadows but we already have

boxShadow: {
    default: 'elevated',
    isArrowShown: 'none'
},

and i'd rather not mess with it just for this.

are we okay with the outline appearing on top of the scrollbar? or can anyone think of a better solution?

i can't clip the scrollbar to the border radius bc that would require overflow: hidden' but we need overflow: auto` so that the outer element gets focused.

outlineWidth: 1,
outlineColor: {
borderStyle: 'solid',
borderWidth: 1,
borderColor: {
default: lightDark('transparent-white-25', 'gray-200'),
forcedColors: 'ButtonBorder'
},
outlineStyle: 'none',
width: {
size: {
// Copied from designs, not sure if correct.
Expand Down Expand Up @@ -154,7 +155,8 @@ let popover = style(
isolation: 'isolate',
pointerEvents: {
isExiting: 'none'
}
},
overflow: 'auto'

@yihuiliao yihuiliao Jun 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right soooo the only issue with overflow: auto is now it clips the arrow...

it would be nice to go this route though bc browsers will focus the scrollable container and then users can keyboard up/down so not much code (but then no arrow)

we might have to shift focus to the inner div instead to preserve the popover's arrow but not sure how that would play around with submenu's for example

@yihuiliao yihuiliao Jun 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow me to cook for a bit...

},
getAllowedOverrides()
);
Expand Down Expand Up @@ -322,7 +324,7 @@ const innerDivStyle = style(
boxSizing: 'border-box',
outlineStyle: 'none',
borderRadius: 'inherit',
overflow: 'auto',
// overflow: 'auto',
position: 'relative',
width: 'full',
maxSize: 'inherit'
Expand Down