Use latest Slack v2 OAuth endpoints. Old endpoints are being deprecated. - #25
Open
chadhutchins wants to merge 1 commit into
Open
Use latest Slack v2 OAuth endpoints. Old endpoints are being deprecated. #25chadhutchins wants to merge 1 commit into
chadhutchins wants to merge 1 commit into
Conversation
Author
|
Hi Adam, can you please consider bringing this in? We're unable to get our slack app submitted to their app store without this change. Can always use a specific fork of course, but would like to stick to your repo. Thanks! |
Contributor
|
Hello @adam-paterson, sorry to spam there, but could this PR be merged and released soon? 🙏 Every new Slack app submission need to use these urls now 😕 |
|
Is anyone maintaining a fork? |
Contributor
|
FYI, I opened #26 to discuss possibilities for the future of this package (maintaining our own fork is an option) 😉 |
Author
|
I ran with this... made a fork with my changes to support Slack v2. I tested it in our production app and all seems good to go. https://packagist.org/packages/chadhutchins/oauth2-slack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Slack apps must use the new v2 oauth flow. The old endpoints will still work for now, but will be deprecated by the end of 2020.