Skip to content

Add BearerAuthorizationTrait - #23

Open
deevus wants to merge 2 commits into
adam-paterson:developfrom
deevus:add-bearer-authorization-trait
Open

Add BearerAuthorizationTrait#23
deevus wants to merge 2 commits into
adam-paterson:developfrom
deevus:add-bearer-authorization-trait

Conversation

@deevus

@deevus deevus commented Dec 12, 2018

Copy link
Copy Markdown

BearerAuthorizationTrait adds the getAuthorizationHeaders function which is used in getAuthenticatedRequest.

I was trying to use getAuthenticatedRequest like I have with other third party providers to query their APIs and noticed that the token wasn't being inserted.

Adds getAuthorizationHeaders method so that clients can use
getAuthenticatedRequest method as expected.
@AndreiIgna

AndreiIgna commented Jan 3, 2019

Copy link
Copy Markdown

I wasn't aware of that trait and made a similar PR some time ago. This one looks cleaner though 👍

As in #22 there's no need to append the token param to URL after this addition

@deevus

deevus commented Jan 4, 2019

Copy link
Copy Markdown
Author

The question remains. Will the owner show up? It's plausible that they're still on holiday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants