Skip to content

Fixed bug when using plasma_density_from_file #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finnerudo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed bug when using plasma_density_from_file #136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
325f658
Fixed bug when using plasma_density_from_file
finnerudo Oct 7, 2025
e91979c
Deleted comment and added error handling
finnerudo Nov 12, 2025
9c915e7
Fixed the comments from last commit
finnerudo Nov 25, 2025
c50ff79
I accidentally deleted some lines last commit
finnerudo Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions abel/classes/stage/impl/stage_hipace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,20 @@ def __extract_initial_and_final_step(self, tmpfolder, beam0, runnable):
def _make_ramp_profile(self, tmpfolder):
"""Prepare the ramps (local to HiPACE)."""

# check that there is not already a plasma density profile set
assert self.plasma_density_from_file is None
# If there is already a density file open and make the plasma profile
if self.plasma_density_from_file:

@kyrsjo kyrsjo Nov 11, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that self.plasma_density_from_file is type str.
Also catch non-existent file, e.g. raise ValueError with meaningful error message

@kyrsjo kyrsjo Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe here explicitly check that it is None, otherwise e.g. False (a bool) or 0 (an int) would have the same meaning as None here but maybe not everywhere else.

ss, ns = [], []
with open(self.plasma_density_from_file, 'r') as f:

@kyrsjo kyrsjo Nov 11, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catch errors when reading / parsing file

for line in f:
s, n = line.strip().split()
ss.append(float(s))
ns.append(float(n))

ss = np.array(ss)
ns = np.array(ns)
self.plasma_profile.ss = ss
self.plasma_profile.ns = ns
return

# make the plasma ramp profile
if self.has_ramp():
Expand Down