Skip to content

Deletion of lastknobposition for certain knobs #7

Description

@tjseydel

I just finished the build of the keyboard. Thanks for providing all the files @ZackFreedman! It was really fun to make and I learned a lot! =D

When testing the firmware I encountered some unexpected behavior where addition keys were pressed when pressing one of the keys. Also, the top and middle wheels seemed not to be working.

For anyone encountering the same issue, I located where the problem arose. Somehow the lastKnobPositions array values were deleted for the top and middle wheel/encoder which causes repeated execution of these linked knobs and thus additional key presses with every key I pressed.

The array values were deleted in lines 580 & 581:
for (int i = 0; i < 6; i++)
lastKnobDeltas[i] = knobDeltas[i];

These lines are not used and can be commented out/deleted to fix the problem.

I have absolutely no idea why these lines cause the array values to be deleted, so if anyone knows, please let me know. I am very curious to see what is causing it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions