Fix intel carrier glow disappearing when Spy cloaks - #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ValveSoftware/Source-1-Games#8047
CCaptureFlag::ShouldHideGlowEffectandCCaptureFlag::Simulatehad two conditions related toLocalPlayerbeing fully cloaked, whereas second one was addingEF_NODRAWand causing flag to blink even if you stand infront of the player holding it, and first one had two conditions to stop rendering glow effect, ifLocalPlayeris fully cloaked orEF_NODRAWis added.I removed both checks of "being fully invisible" from the code since they don't seem to have any reason to exist, and more like some old code that was "fixing" something else (since git blame shows they are from first release of TF2 code in Source SDK 2013)
This is how it looks currently in Team Fortress 2 (as of 6/4/2026)
tf_win64_O7nIMumUFj.mp4
This is how it looks after patch applied.
NVIDIA_Overlay_a7jnTnYLJh.mp4