Skip to content

feat(gui:list): allow copying package-names #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lawson85 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(gui:list): allow copying package-names #1377

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7a2e25
Added ability to copy package names
lawson85 Apr 6, 2026
a264a54
Update package_row.rs
lawson85 Apr 6, 2026
54319b3
Merge branch 'Universal-Debloater-Alliance:main' into main
lawson85 Apr 6, 2026
a07a785
Cleanup
lawson85 Apr 6, 2026
6654f20
Cargo fmt
lawson85 Apr 6, 2026
56e245e
Comment
lawson85 Apr 7, 2026
0092b4f
Cargo fmt
lawson85 Apr 7, 2026
7202a4d
Cargo fmt
lawson85 Apr 7, 2026
c65f46b
Restore some changes that broke things
lawson85 Apr 7, 2026
f84ae54
Cargo fmt
lawson85 Apr 7, 2026
c3d8ddb
deleted // and cargo fmt
lawson85 Apr 7, 2026
7ff19e7
Update src/gui/widgets/package_row.rs
lawson85 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/gui/views/list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ use crate::core::uad_lists::{
};
use crate::core::utils::{EXPORT_FILE_NAME, NAME, export_selection, fetch_packages, open_url};
use crate::gui::style;
use crate::gui::views::settings::Settings;
use crate::gui::widgets::modal::Modal;
use crate::gui::widgets::navigation_menu::ICONS;
use crate::gui::widgets::package_row::Message as PackageRowMessage;
use std::path::PathBuf;

use crate::gui::views::settings::Settings;
use crate::gui::widgets::modal::Modal;
use crate::gui::widgets::package_row::{Message as RowMessage, PackageRow};
use crate::gui::widgets::text;
Comment on lines +10 to 17
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageRowMessage is an alias of the same enum already imported as RowMessage from package_row. Importing both and matching on PackageRowMessage::Noop while using RowMessage::* for the other variants is redundant and makes the match harder to follow; it can be simplified by using a single alias (e.g., RowMessage::Noop) and removing the extra import.

Copilot uses AI. Check for mistakes.
use iced::widget::scrollable::{Direction, Scrollbar};
Expand Down Expand Up @@ -952,6 +953,7 @@ impl List {
let package = &mut self.phone_packages[i_user][i_package];

match *row_message {
PackageRowMessage::Noop => Task::none(),
RowMessage::ToggleSelection(toggle) => {
if package.removal == Removal::Unsafe && !settings.general.expert_mode {
package.selected = false;
Expand Down
8 changes: 6 additions & 2 deletions src/gui/widgets/package_row.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use crate::core::uad_lists::{PackageState, Removal, UadList};
use crate::gui::style;
use crate::gui::views::settings::Settings;
use crate::gui::widgets::text;

use iced::widget::text_input;
use iced::widget::{Space, button, checkbox, row};
use iced::{Alignment, Element, Length, Renderer, Task, alignment};

Expand All @@ -24,6 +24,7 @@ pub enum Message {
PackagePressed,
ActionPressed,
ToggleSelection(bool),
Noop,
}

impl PackageRow {
Expand Down Expand Up @@ -123,7 +124,10 @@ impl PackageRow {
button(
row![
selection_checkbox,
text(&self.name).width(Length::FillPortion(8)),
text_input("", &self.name)
.on_input(|_| Message::Noop)
Comment thread
lawson85 marked this conversation as resolved.
.padding(0)
.size(16),
action_btn.style(button_style)
]
.spacing(8)
Expand Down
Loading