return xr.DataArray for angle_to_direction if input is xr.DataArray - #3463
Closed
raybellwaves wants to merge 4 commits into
Closed
return xr.DataArray for angle_to_direction if input is xr.DataArray#3463raybellwaves wants to merge 4 commits into
raybellwaves wants to merge 4 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Was hoping it would work out of the box. No idea why it's outputting "N" instead of "W" |
Contributor
Author
|
ah think I found it the xarray objects get assigns units "dimensionless" early on
|
Contributor
Author
|
happy with this. Nice work on |
Contributor
Author
|
nvm. Bit too much whack-a-mole getting it work for xarray then to have it failing for the scalar and list test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
return xr.DataArray for angle_to_direction if input is xr.DataArray
Checklist