Skip to content

Fix disallowed-character stripping when replacement is an empty string #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 4 commits into from
Jul 21, 2026
+8 −1
Merged

Fix disallowed-character stripping when replacement is an empty string #559

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8588f4
fix: sanitize disallowed characters when replacement is an empty string
SimYunSup Jul 21, 2026
3619209
Apply suggestion from @Trott
Trott Jul 21, 2026
5c95f4d
Apply suggestion from @Trott
Trott Jul 21, 2026
41fe159
Apply suggestion from @Trott
Trott Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function slugify (string, opts) {
char = localeMap[char]
} else if (opts.charmap[char]) {
char = opts.charmap[char].replace(opts.replacement, ' ')
} else if (char.includes(opts.replacement)) {
} else if (opts.replacement !== '' && char.includes(opts.replacement)) {
// preserve the replacement character in case it is excluded by disallowedChars
char = char.replace(opts.replacement, ' ')
} else {
Expand Down
9 changes: 9 additions & 0 deletions test/slug.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ describe('slug', function () {
assert.strictEqual(slug('foo bar baz', ''), 'foobarbaz')
})

it('should sanitize disallowed characters even with an empty replacement', function () {
assert.strictEqual(slug('<script>alert(1)</script>', ''), 'scriptalert1script')
assert.strictEqual(slug('a/../../etc/passwd', ''), 'aetcpasswd')
Comment thread
Trott marked this conversation as resolved.
Outdated
assert.strictEqual(slug('a<b>c', ''), 'abc')
assert.strictEqual(slug('a<b>c', { replacement: '', mode: 'rfc3986' }), 'abc')
// documented behavior must remain intact
Comment thread
Trott marked this conversation as resolved.
Outdated
assert.strictEqual(slug('foo bar baz', ''), 'foobarbaz')
})

it('should replace multiple spaces and dashes with a single instance', function () {
assert.strictEqual(slug('foo bar--baz'), 'foo-bar-baz')
})
Expand Down